Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pending secure messaging logic to EntryWidget #1124

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Add pending secure messaging logic to EntryWidget #1124

merged 1 commit into from
Nov 22, 2024

Conversation

EgorovEI
Copy link
Contributor

MOB-3653

What was solved?
This commit adds next logic into EntryWidget.show(in:) method implementation:

  • if pending secure messaging exists ChatTranscript screen will be opened.
  • otherwise EntryWidget Bottom Sheet will be shown. Commit also adds unit test.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

@EgorovEI EgorovEI marked this pull request as ready for review November 21, 2024 11:22
@EgorovEI EgorovEI requested a review from 1toomas November 22, 2024 07:26
@EgorovEI
Copy link
Contributor Author

!squash

Add pending secure messaging logic to EntryWidget
c734b58 
This commit adds next logic into EntryWidget.show(in:) method implementation:
- if pending secure messaging exists ChatTranscript screen will be opened.
- otherwise EntryWidget Bottom Sheet will be shown.
Commit also adds unit test.

MOB-3653
@sm-deployer sm-deployer force-pushed the task/MOB-3653-entry-widgets-pending-conversation-logic branch from 2a293ae to c734b58 Compare November 22, 2024 07:42
@EgorovEI EgorovEI requested a review from DavDo November 22, 2024 07:42
@EgorovEI EgorovEI merged commit 7b2be9e into feature/entry-widget-and-secure-conversations-v2 Nov 22, 2024
8 checks passed
@EgorovEI EgorovEI deleted the task/MOB-3653-entry-widgets-pending-conversation-logic branch November 22, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykyivskyi-gl ykyivskyi-gl ykyivskyi-gl approved these changes

@1toomas 1toomas 1toomas approved these changes

@igorkravchenko igorkravchenko igorkravchenko approved these changes

@rasmustautsglia rasmustautsglia Awaiting requested review from rasmustautsglia

@DavDo DavDo Awaiting requested review from DavDo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EgorovEI @igorkravchenko @1toomas @ykyivskyi-gl